From 136b22bc1bc6e0fef683851e2b802c9e767600b7 Mon Sep 17 00:00:00 2001
From: Peter Woolery <peter@research.bike>
Date: Mon, 13 Apr 2026 14:33:12 -0700
Subject: [PATCH] =?UTF-8?q?fix:=20cv=5Finit=20=E2=80=94=20replace=20memset?=
 =?UTF-8?q?=20with=20value-init=20to=20avoid=20UB=20on=20std::vector?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Also fix stale path comment in test/test_cv/test_cv.cpp.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 firmware/lib/cv/cv.cpp            | 2 +-
 firmware/test/test_cv/test_cv.cpp | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/firmware/lib/cv/cv.cpp b/firmware/lib/cv/cv.cpp
index 46f1fff..0928296 100644
--- a/firmware/lib/cv/cv.cpp
+++ b/firmware/lib/cv/cv.cpp
@@ -5,7 +5,7 @@
 #include <algorithm>
 
 void cv_init(CVState& state) {
-    memset(&state, 0, sizeof(CVState));
+    state = CVState{};   // value-initialize — calls vector default ctor correctly
     state.next_id = 1;
 }
 
diff --git a/firmware/test/test_cv/test_cv.cpp b/firmware/test/test_cv/test_cv.cpp
index ecdc9be..edea2b9 100644
--- a/firmware/test/test_cv/test_cv.cpp
+++ b/firmware/test/test_cv/test_cv.cpp
@@ -1,4 +1,4 @@
-// firmware/test/test_native/test_cv.cpp
+// firmware/test/test_cv/test_cv.cpp
 #include <unity.h>
 #include <string.h>
 #include "cv.h"