docs: refresh HANDOFF + ORIENTATION for Phase 6 completion

This commit is contained in:
2026-05-08 21:46:04 -07:00
parent aea47d8365
commit 0d70fb118d
2 changed files with 43 additions and 41 deletions
+15 -11
View File
@@ -15,7 +15,7 @@ Constraint that drives the design: 3 of 4 members do not like mushrooms; family
## Architecture (current)
```
email ─► SendGrid (Phase 6, not yet wired) ──┐
email ─► SendGrid ───────────────────────────┐
web ─► nginx :80/:443 ─► React/Vite ───────┼─► FastAPI ──► PostgreSQL 15
│ │
│ └─► Swiftly JSON API
@@ -25,7 +25,7 @@ web ─► nginx :80/:443 ─► React/Vite ───────┼─► Fas
scheduler ─► APScheduler (America/Los_Angeles)
Fri 02:00 scrape → 05:00 generate → 06:00 email
Fri 17:00 deadline → 18:00 finalize+shopping-list
Fri 16:00 reminder → 17:00 deadline → 18:00 finalize+shopping-list
(same backend image; command: python -m app.scheduler)
```
@@ -36,7 +36,7 @@ scheduler ─► APScheduler (America/Los_Angeles)
---
## Phase status (2026-05-07)
## Phase status (2026-05-08)
| # | Phase | Status |
|---|---|---|
@@ -45,14 +45,14 @@ scheduler ─► APScheduler (America/Los_Angeles)
| 3 | Lucky California ingestion (Swiftly JSON API) | **Complete** — 17 categories, ~10k products live |
| 4 | Recipe engine (CRUD, search, tagging, never-suggest filter) | **Thin slice complete** — recipe + ingredient CRUD, ingredient↔grocery match layer (rapidfuzz, manual override), NeverSuggest CRUD, 30-recipe seed. Ingestion source decision deferred (see spec). |
| 5 | Meal planner orchestration (generate → email → vote → finalize) | **Complete** — Friday Pacific cadence; APScheduler container; `weekly_run` state table; idempotent steps; stale-data fallback; configurable deadline policy. |
| 6 | SendGrid email integration (proposal/reminder/confirmation) | Stub only — `app/services/email.py::SendGridEmailBackend` raises NotImplementedError |
| 6 | SendGrid email integration (proposal/reminder/confirmation) | **Complete**`SendGridEmailBackend` live; `step_reminder` (Fri 16:00 PT) nudges non-voters; all templates HTML-safe. |
| 7 | Web UI core (Dashboard / Meal Detail / Pantry / Shopping List) | **Complete** (no auth UI yet) |
| 8 | Web UI feedback portal | Not started |
| 9 | Meal-planner generation algorithm | **Complete** — POST /api/admin/meal-plans/generate produces 3-dinner plans against seeded recipes + matched grocery prices. Filter (6 hard constraints), score (5 signals), top-K=20 set enumeration with diversity penalty. |
| 10 | Image strategy (scraped + AI fallback) | Not started |
| 11 | Polish (variety analysis, budget tracking, APScheduler) | Not started |
Verification gate (current, 2026-05-07): **115/115 pytest green**; alembic upgrade→downgrade→upgrade clean; frontend `npm run build` clean; live scrape persists **9,980 grocery_item rows in 44 s** with auto-minted JWT (no env var); 29,779 ingredient_grocery_match rows produced; email approval round-trip (approve/deny/single-use) verified end-to-end; scheduler container starts with all 5 Friday jobs registered.
Verification gate (current, 2026-05-08): **123/123 pytest green**; alembic upgrade→downgrade→upgrade clean (00010009); frontend `npm run build` clean; live scrape persists **9,980 grocery_item rows in 44 s** with auto-minted JWT (no env var); 29,779 ingredient_grocery_match rows produced; email approval round-trip (approve/deny/single-use) verified end-to-end; scheduler container starts with all **6** Friday jobs registered.
---
@@ -74,7 +74,7 @@ Conventions: UUID PKs everywhere, `TIMESTAMPTZ`, Postgres ENUMs (with `values_ca
Key relationships: `family_profile``family_member`; `family_member``meal_plan_vote` (per-voter); `recipe.ingredients` JSONB (no recipe-ingredient join table); `grocery_item.(source, external_id)` is the upsert key for scrape ingestion.
Migrations applied: 0001 initial, 0002 seed (idempotent via `ON CONFLICT DO NOTHING`), 0003 grocery_item.description, 0004 family_profile.calorie_target, 0005 grocery_item.external_id + source + composite index, 0006 thin Phase 4 (ingredient.aliases, recipe.calories_per_serving, ingredient_grocery_match), 0007 seed canonical ingredients (50) + 30 starter recipes, 0008 Phase 5 (`weekly_run` table + `family_profile.pending_approval_policy`).
Migrations applied: 0001 initial, 0002 seed (idempotent via `ON CONFLICT DO NOTHING`), 0003 grocery_item.description, 0004 family_profile.calorie_target, 0005 grocery_item.external_id + source + composite index, 0006 thin Phase 4 (ingredient.aliases, recipe.calories_per_serving, ingredient_grocery_match), 0007 seed canonical ingredients (50) + 30 starter recipes, 0008 Phase 5 (`weekly_run` table + `family_profile.pending_approval_policy`), 0009 Phase 6 (`weekly_run.reminded_at TIMESTAMPTZ NULL`).
Full schema: `docs/database-schema.md`.
@@ -94,7 +94,9 @@ SESSION_PASSWORD=... # family-shared password for /api/auth/login
# Email
EMAIL_BACKEND=console # 'console' (default) or 'sendgrid'
SENDGRID_API_KEY=... # only when EMAIL_BACKEND=sendgrid (Phase 6)
SENDGRID_API_KEY=... # required when EMAIL_BACKEND=sendgrid
SENDGRID_FROM_EMAIL=peter@research.bike # sender address (default)
SENDGRID_REPLY_TO=peter@research.bike # reply-to address (default)
# Phase 5 orchestration
ADMIN_EMAIL=... # alert destination; empty = alerts dropped silently
@@ -122,11 +124,11 @@ The Swiftly bearer JWT is auto-minted at request time via Firebase REST anon-sig
# Full local stack (include scheduler for Phase 5)
docker compose --env-file .env.test up -d db backend scheduler
docker compose --env-file .env.test exec backend alembic upgrade head
docker compose --env-file .env.test exec -e TEST_DATABASE_URL=postgresql://mealplanner:${POSTGRES_PASSWORD}@db:5432/mealplanner backend pytest -q tests/ # → 115 passed
docker compose --env-file .env.test exec -e TEST_DATABASE_URL=postgresql://mealplanner:${POSTGRES_PASSWORD}@db:5432/mealplanner backend pytest -q tests/ # → 123 passed
# Verify scheduler
docker compose --env-file .env.test logs scheduler | grep Registered
# Expected: 5 lines — scrape/generate/email/deadline/finalize
# Expected: 6 lines — scrape/generate/email/reminder/deadline/finalize
# Manual step trigger (useful for testing without waiting for Friday)
curl -X POST http://localhost:8000/api/admin/orchestrate/scrape \
@@ -149,7 +151,7 @@ A `.env.test` template lives in the repo root (gitignored) for local stack runs.
- API paths: no trailing slash, no `/list`/`/planned` suffixes.
- Tests: pytest; `requires_postgres` marker auto-skips locally without `TEST_DATABASE_URL`.
- Migrations: Alembic only. Never `Base.metadata.create_all()` at runtime.
- Background work: FastAPI `BackgroundTasks` for on-demand scrape. APScheduler `BlockingScheduler` in the `scheduler` container for the weekly cycle (Phase 5 complete).
- Background work: FastAPI `BackgroundTasks` for on-demand scrape. APScheduler `BlockingScheduler` in the `scheduler` container for the weekly cycle (6 Friday Pacific jobs — Phases 5+6 complete).
---
@@ -164,9 +166,11 @@ A `.env.test` template lives in the repo root (gitignored) for local stack runs.
- `docs/specs/2026-05-05-meal-planner-algorithm-design.md` — Phase 9 + thin Phase 4 design.
- `docs/specs/2026-05-06-swiftly-token-auto-mint.md` — Swiftly JWT auto-mint design (Implemented 2026-05-06).
- `docs/superpowers/plans/2026-05-07-phase5-orchestration.md` — Phase 5 implementation plan (executed 2026-05-07).
- `docs/superpowers/specs/2026-05-07-phase6-sendgrid-design.md` — Phase 6 design spec.
- `docs/superpowers/plans/2026-05-07-phase6-sendgrid.md` — Phase 6 implementation plan (executed 2026-05-08).
- `.agent/plan.md`, `.agent/context.md`, `.agent/phase-summaries/` — recovery decisions and per-phase summaries from the R1+R2+R3-0 work.
- `Review/reviewconcensus.md` — the adversarial review that drove the recovery.
---
Last updated: 2026-05-07 — Phase 5 weekly orchestration shipped; 115/115 pytest green; scheduler container live with 5 Friday Pacific jobs. Next pickup: Phase 6 SendGrid.
Last updated: 2026-05-08 — Phase 6 SendGrid shipped; 123/123 pytest green; scheduler container live with 6 Friday Pacific jobs. Next pickup: Frontend login UI.