Public Access
docs(review): Sprint 4 verification log + plan/handoff/audit updates
Sprint 4 (F7 + F6) is now documented across the project: - Review/sprint4-verification.md: new 100-line deploy + smoke-check doc. Frontend-only deploy (git pull + docker compose up -d --build frontend). 5 smoke-check tables: A) success toasts still work for all 11 actions, B) error path shows FastAPI detail (network-down is the easiest test; full Pydantic 422 verification via curl + DevTools 'Edit and resend'), C) pre-flight toasts still fire without a network call, D) plan-status Badge has correct aria-label in DevTools, E) Sprint 1-3 regression spot-check. Includes rollback instructions (single-commit revert). - fix-ui-audit.md: new Sprint 4 section with full per-task notes (S4.1 F7 implementation details, S4.2 F6 aria-label, S4.3 verification gate). 'Done when (overall)' block updated to 4 sprints + 7 commits + 16 findings closed. No new commit in fix-ui-audit.md for the F8/F9 §Future addendum (those are noted in Review/handoff-ui-audit.md but live in the doc/proposals/ tree, not in the UI-audit plan). - Review/handoff-ui-audit.md: updated to a 4-sprint cycle. TL;DR table includes thed71b67arow, file-list includes the new verification doc, file-level diff summary gains 5 new rows for Sprint 4, §Future list now strikethroughs F6 and F7, and the Quick-start deploy commands list Sprint 4. - Review/ui-nielsen-audit.md: new Sprint 4 status block at the top with the F7/F6 changes, the no-backend-changes note, and a cross-ref to the new verification log. - docs/HANDOFF.md: Last-updated line bumped to 4 sprints / 7 commits / 16 findings. New 'Sprint 4' subsection in the 2026-06-03 session block. Commit table gained thed71b67arow. Files-modified list gained the lib/toast.tsx, App.tsx, and three pages changes for Sprint 4 (with B-tags preserved). No code changes; the 5 pre-existing WIP files (backend/app/api/ meals.py, recipes.py, schemas/recipe.py, frontend/src/api/index.ts, nginx/nginx.conf) are deliberately not staged.
This commit is contained in:
+18
-11
@@ -1,6 +1,6 @@
|
||||
# UI/UX Audit & Fix — Agent Handoff
|
||||
|
||||
You are taking over a 3-sprint UI/UX audit and fix cycle. All code changes are committed and build green. The user's deployment host (Tailscale `100.108.224.12`) is the only environment you should touch for verification — the local repo on this machine (`/home/peter/Projects/MealPlanner`) was the editing host; the running app lives elsewhere.
|
||||
You are taking over a 4-sprint UI/UX audit and fix cycle. All code changes are committed and build green. The user's deployment host (Tailscale `100.108.224.12`) is the only environment you should touch for verification — the local repo on this machine (`/home/peter/Projects/MealPlanner`) was the editing host; the running app lives elsewhere.
|
||||
|
||||
**Date of handoff: 2026-06-03.**
|
||||
|
||||
@@ -8,17 +8,18 @@ You are taking over a 3-sprint UI/UX audit and fix cycle. All code changes are c
|
||||
|
||||
## TL;DR
|
||||
|
||||
Three commits land all 14 audit findings from `Review/ui-nielsen-audit.md`:
|
||||
Four commits land all 14 audit findings + 2 of the §Future items:
|
||||
|
||||
| Sprint | Commit | Scope | Build | Deploy |
|
||||
|---|---|---|---|---|
|
||||
| 1 | `f3e4a44` | 5 P0 blockers | ✅ green | ✅ deployed 2026-06-02 by user |
|
||||
| 2 | `ccc70aa` + `f5fb755` | 6 P1s + bonus S3.3 | ✅ green | ⚠️ not yet deployed |
|
||||
| 3 | `e90a9d6` | 3 P2s + a11y sweep | ✅ green | ⚠️ not yet deployed |
|
||||
| 4 | `d71b67a` | F7 global error handler + F6 plan-status aria-label | ✅ green | ⚠️ not yet deployed |
|
||||
|
||||
All work is on `main` ahead of `origin/main` (pre-existing WIP also present). All three sprints compile. **Sprint 1 is live. Sprints 2 and 3 are not yet live on `100.108.208.56:8082/`.**
|
||||
All work is on `main` ahead of `origin/main` (pre-existing WIP also present). All four sprints compile. **Sprint 1 is live. Sprints 2, 3, and 4 are not yet live on `100.108.208.56:8082/`.** Sprint 4 is frontend-only (no backend changes); Sprint 2 includes a backend migration; Sprints 3 and 4 are pure frontend.
|
||||
|
||||
**Next action:** the user runs the deploy commands in `Review/sprint2-verification.md` and `Review/sprint3-verification.md` on the deployment host, then smoke-checks per the checklists. After verification, any remaining items move to the §Future backlog in `fix-ui-audit.md`.
|
||||
**Next action:** the user runs the deploy commands in `Review/sprint2-verification.md`, `Review/sprint3-verification.md`, and `Review/sprint4-verification.md` on the deployment host, then smoke-checks per the checklists. After verification, any remaining items move to the §Future backlog in `fix-ui-audit.md` (F1 onboarding, F2 keyboard shortcuts, F3 bulk add, F4 plan-whole-week, F5 URL week selector, F8 Spoonacular enrichment, F9 Ollama matcher — F6 and F7 now done in Sprint 4).
|
||||
|
||||
---
|
||||
|
||||
@@ -30,17 +31,18 @@ All work is on `main` ahead of `origin/main` (pre-existing WIP also present). Al
|
||||
│ ├── ui-nielsen-audit.md # The audit (276 → ~340 lines). Status blocks per sprint at the top.
|
||||
│ ├── sprint2-verification.md # Deploy + smoke checks for Sprint 2 (BACKEND MIGRATION INCLUDED).
|
||||
│ ├── sprint3-verification.md # Deploy + smoke checks for Sprint 3 (frontend only).
|
||||
│ ├── sprint4-verification.md # Deploy + smoke checks for Sprint 4 (F7+F6, frontend only).
|
||||
│ ├── docs-claude.md # Prior docs adversarial review (not yours).
|
||||
│ ├── docs-gpt5.5.md # Prior docs adversarial review.
|
||||
│ ├── repo-gpt5.5.md # Prior repo adversarial review.
|
||||
│ ├── reviewconcensus.md # Prior review consensus.
|
||||
│ └── synthesis.md # Prior review synthesis.
|
||||
├── fix-ui-audit.md # The plan (232 lines). Implementation notes per task + commit refs.
|
||||
├── fix-ui-audit.md # The plan. Implementation notes per task + commit refs. Sprint 4 added.
|
||||
├── docs/HANDOFF.md # The project-wide handoff (don't duplicate — read for context).
|
||||
└── docs/ORIENTATION.md # Project orientation.
|
||||
```
|
||||
|
||||
**Read first**, in this order: `docs/ORIENTATION.md` → `docs/HANDOFF.md` → `Review/ui-nielsen-audit.md` (the audit) → `fix-ui-audit.md` (the plan) → the two `sprintN-verification.md` files.
|
||||
**Read first**, in this order: `docs/ORIENTATION.md` → `docs/HANDOFF.md` → `Review/ui-nielsen-audit.md` (the audit) → `fix-ui-audit.md` (the plan) → the three `sprintN-verification.md` files.
|
||||
|
||||
---
|
||||
|
||||
@@ -137,14 +139,14 @@ The user's flow is: read the smoke check, run the deploy, click around, mark eac
|
||||
|
||||
## What's NOT in scope (per audit §Future)
|
||||
|
||||
The audit intentionally deferred these. If the user asks, they become a new plan:
|
||||
F6 and F7 are done in Sprint 4. The audit intentionally deferred these. If the user asks, they become a new plan:
|
||||
- F1. Onboarding hints / tour (H10)
|
||||
- F2. Keyboard shortcuts (`/`, `g p`, `g s`, `n m`)
|
||||
- F3. Bulk add on Pantry/Shopping List (H7)
|
||||
- F4. Plan-the-whole-week button (H7)
|
||||
- F5. Persistent week selector in URL
|
||||
- F6. Badge a11y for color-only signals (generalized — the current badges are text+color)
|
||||
- F7. Global `react-query` `onError` toast handler
|
||||
- ~~F6. Badge a11y for color-only signals (generalized)~~ — done in Sprint 4
|
||||
- ~~F7. Global `react-query` `onError` toast handler~~ — done in Sprint 4
|
||||
- F8. Backend Spoonacular enrichment (separate proposal in `docs/proposals/`)
|
||||
- F9. Ollama LLM matcher (separate proposal in `docs/proposals/`)
|
||||
|
||||
@@ -176,6 +178,11 @@ The audit intentionally deferred these. If the user asks, they become a new plan
|
||||
| 3 | `frontend/src/pages/Pantry.tsx` | B12: reversible undo on remove |
|
||||
| 3 | `frontend/src/App.tsx` | B13 + S3.5: nav nowrap, aria-current, main id |
|
||||
| 3 | `frontend/src/components/ui/Badge.tsx` | S3.5: icon + aria-label props |
|
||||
| 4 | `frontend/src/lib/toast.tsx` | F7: extractErrorMessage + showApiError |
|
||||
| 4 | `frontend/src/App.tsx` | F7: QueryCache/MutationCache onError + queries defaultOptions |
|
||||
| 4 | `frontend/src/pages/Dashboard.tsx` | F7: removed 6 local onError; F6: plan-status aria-label |
|
||||
| 4 | `frontend/src/pages/Pantry.tsx` | F7: removed 3 local onError; undo now uses showApiError |
|
||||
| 4 | `frontend/src/pages/MealDetail.tsx` | F7: removed submitMutation.onError |
|
||||
|
||||
---
|
||||
|
||||
@@ -200,9 +207,9 @@ git log origin/main..HEAD --oneline
|
||||
# - Sprint 2: docker compose exec db psql -U mealplanner -d mealplanner \
|
||||
# -f /dev/stdin < backend/scripts/persist_aisle_backup.sql
|
||||
# - docker compose exec backend alembic upgrade head
|
||||
# - docker compose -f docker-compose.yml up -d --build frontend
|
||||
# - Sprint 3: docker compose -f docker-compose.yml up -d --build frontend
|
||||
# See Review/sprint{2,3}-verification.md for the full checklist.
|
||||
# - Sprint 4: docker compose -f docker-compose.yml up -d --build frontend
|
||||
# See Review/sprint{2,3,4}-verification.md for the full checklist.
|
||||
|
||||
# 4. If you need to take new screenshots after changes
|
||||
# /tmp/opencode/mp-review/shoot-sprint1.js is a working playwright harness.
|
||||
|
||||
Reference in New Issue
Block a user