Files
Meal-Planner/backend/alembic/versions/0005_grocery_item_external_id.py
adminandClaude Opus 4.7 8e89f793d5 feat: phase r1+r2 recovery + r3-0 swiftly api ingestion
R1 stabilization: pytest harness with transactional db fixture, smoke
+ alembic + auth + scrape + approval + swiftly tests, github actions
ci yaml. Bearer-token admin auth + signed-cookie session for family
ui mutations. Async POST /api/admin/scrape (BackgroundTasks, returns
202). Path canonicalization (no /list, /planned suffixes). DATABASE_URL
fail-fast on empty.

R2 deferred-risk spikes: live lucky california fetch (R2-A), full
email+per-voter approval click round trip with single-use enforcement
(R2-B, console email backend, sendgrid stub).

R3-0 phase 3 redesign: replaced playwright html scraper with requests
based swiftly json api client. 17 categories, ~10k products per scrape,
upsert by (source, external_id). 401 surfaces actionable token-refresh
message via ScrapeLog.error_message.

Pre-existing defects fixed: shopping_list.py syntax error blocking app
import, MealPlan.votes orphan relationship, JSONB(astext=True) invalid
kwarg, missing requests dep, calorie_target schema drift, every SQLEnum
needed values_callable, 0001 had empty downgrade(), seed had duplicate
ingredient rows.

Migrations added: 0003 grocery_item.description, 0004 family_profile.
calorie_target, 0005 grocery_item.external_id + source + composite index.

Verified: 31/31 pytest green, alembic upgrade->downgrade->upgrade clean,
frontend npm run build clean, live scrape 9,960 grocery_item rows in 36s.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-05 14:08:19 -07:00

49 lines
1.4 KiB
Python

"""Add nullable indexed external_id and source columns to grocery_item.
The Swiftly API exposes a stable ``id`` per product (e.g. ``"46556"``).
Persisting it as ``grocery_item.external_id`` lets the scraper UPSERT by
``(source, external_id)`` rather than create duplicates on every run.
``source`` distinguishes overlapping IDs across future banners (e.g. a
second Save Mart store using the same Swiftly tenant). See R3-0 notes in
``.agent/phase-summaries/r3-0-summary.md``.
Revision ID: 0005
Revises: 0004
Create Date: 2026-05-05
"""
from typing import Sequence, Union
from alembic import op
import sqlalchemy as sa
revision: str = '0005'
down_revision: Union[str, None] = '0004'
branch_labels: Union[str, Sequence[str], None] = None
depends_on: Union[str, Sequence[str], None] = None
def upgrade() -> None:
op.add_column(
"grocery_item",
sa.Column("external_id", sa.String(length=100), nullable=True),
)
op.add_column(
"grocery_item",
sa.Column(
"source", sa.String(length=50), nullable=True,
),
)
op.create_index(
"ix_grocery_item_source_external_id",
"grocery_item",
["source", "external_id"],
unique=False,
)
def downgrade() -> None:
op.drop_index("ix_grocery_item_source_external_id", table_name="grocery_item")
op.drop_column("grocery_item", "source")
op.drop_column("grocery_item", "external_id")